Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][ADD] Add crm_lead_approval module #627

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

vehi-invitu
Copy link

No description provided.

@vehi-invitu vehi-invitu marked this pull request as draft January 15, 2025 01:06
@vehi-invitu vehi-invitu force-pushed the 17.0-add_crm_lead_approval branch 2 times, most recently from 9d38976 to ba541b5 Compare January 15, 2025 01:30
@cvinh
Copy link

cvinh commented Jan 15, 2025

readme is missing + i18n

@cvinh
Copy link

cvinh commented Jan 15, 2025

Tests are failing because of crm_salesperson_planner

@vehi-invitu vehi-invitu force-pushed the 17.0-add_crm_lead_approval branch from ba541b5 to cf71f57 Compare January 15, 2025 22:26
Copy link

@cvinh cvinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add CONFIGURATION and USAGE in readme

@vehi-invitu vehi-invitu force-pushed the 17.0-add_crm_lead_approval branch from cf71f57 to 2ea83f5 Compare January 15, 2025 23:27
@vehi-invitu vehi-invitu force-pushed the 17.0-add_crm_lead_approval branch 3 times, most recently from 96e68ca to 964de8e Compare January 16, 2025 23:55
@vehi-invitu vehi-invitu marked this pull request as ready for review January 17, 2025 00:23
@vehi-invitu vehi-invitu force-pushed the 17.0-add_crm_lead_approval branch from 964de8e to 1958cf6 Compare January 17, 2025 00:29
@vehi-invitu vehi-invitu force-pushed the 17.0-add_crm_lead_approval branch 2 times, most recently from 26ae56f to 6f4e0b8 Compare January 17, 2025 19:48
Copy link

@cvinh cvinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@vehi-invitu vehi-invitu force-pushed the 17.0-add_crm_lead_approval branch 2 times, most recently from 759fda9 to 0d74506 Compare February 7, 2025 20:26
@vehi-invitu vehi-invitu force-pushed the 17.0-add_crm_lead_approval branch from 7dc3582 to 8d1cd99 Compare February 11, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants